Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SY-1179 fix update available button not appearing #828

Merged
merged 2 commits into from
Sep 16, 2024
Merged

SY-1179 fix update available button not appearing #828

merged 2 commits into from
Sep 16, 2024

Conversation

emilbon99
Copy link
Contributor

@emilbon99 emilbon99 commented Sep 14, 2024 •
edited
Loading

Fix Pull Request Template

Key Information

Description

Fixes the update available notification not showing the 'Update' button.

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added sufficient regression tests to cover the changes to CI.
  • I have added relevant tests to cover the changes or exposing bugs.
  • I have verified code coverage targets are met.

Additional Notes

  • These changes deal with concurrency.
  • These changes affect UI.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Reviewer Checklist

  • Sufficient test coverage of new additions.
  • Verified all steps in readiness checklists.
  • UI changes have been tested.
  • style and formatting is consistent.
  • Reviewed any relevant changes to concurrent code for safety.
  • Sufficient comments and clarity of code.

@emilbon99 emilbon99 changed the base branch from main to rc September 14, 2024 16:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.36%. Comparing base (dc384c8) to head (20a2a83).
Report is 3 commits behind head on rc.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##               rc     #828   +/-   ##
=======================================
  Coverage   46.36%   46.36%           
=======================================
  Files        1088     1088           
  Lines       67830    67843   +13     
  Branches     3514     3513    -1     
=======================================
+ Hits        31446    31453    +7     
- Misses      35334    35341    +7     
+ Partials     1050     1049    -1
Flag Coverage Δ
aspen 50.40% <ø> (ø)
cesium 75.53% <ø> (ø)
clientpy 86.04% <ø> (ø)
clientts 61.35% <ø> (ø)
drift 26.30% <ø> (-0.08%) ⬇️
freighterpy 81.03% <ø> (ø)
freighterts 83.25% <ø> (ø)
pluto 35.40% <ø> (+<0.01%) ⬆️
synnax 28.51% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lham42 Lham42 changed the title Sy 1179 fix update available button not appearing SY-1179 fix update available button not appearing Sep 16, 2024
@Lham42 Lham42 merged commit 7746fae into rc Sep 16, 2024
33 of 34 checks passed
@pjdotson pjdotson deleted the sy-1179-fix-update-available-button-not-appearing branch October 3, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjdotson pjdotson pjdotson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilbon99 @codecov-commenter @pjdotson @Lham42